Switch from travis ci to github actions #466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelson
commented
Nov 29, 2020
| @@ -11,7 +11,7 @@ | |||
| ;; Created: Mon Nov 7 2011 | |||
| ;; Keywords: languages elixir | |||
| ;; Version: 2.4.0 | |||
| ;; Package-Requires: ((emacs "24") (pkg-info "0.4")) | |||
| ;; Package-Requires: ((emacs "24") (pkg-info "0.4") (s "1.2.0")) | |||
There was a problem hiding this comment.
Since s is only used for tests this should be changed so it's not a general requirement of the package. Unfortunately I wasn't able to find any information on how to accomplish that
There was a problem hiding this comment.
Doesn't that help? https://github.com/doublep/eldev#additional-dependencies
axelson
commented
Nov 29, 2020
| otp: 23.1.4 | ||
| env: | ||
| MIX_ENV: test | ||
| ERT_RUNNER_ARGS: |
There was a problem hiding this comment.
Instead of adding this here, the tests should not try to read this environment variable
|
I've submitted #471 that addresses most comments and some others here. |
|
@axelson I guess we can close this one now right? |
|
yup! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up as a starting place for moving away from travis, although perhaps we should stick with cask for now instead of trying to switch to eldev at the same time. But I'm having trouble getting everything setup, I've left a couple comments on things that should be changed but there are probably more issues.